Conversation
Contributor
🔒 Dependency Security Report✅ No dependency changes detected in this PR. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new filesystem provider that mounts an NFS export locally and then reuses the existing LocalFileSystemProvider logic to index/browse/play media from the mounted path.
Changes:
- Introduces
filesystem_nfsprovider module with config flow and mount/unmount implementation. - Adds NFS provider manifest and icons.
- Expands filesystem local ignore-directory list (e.g., adds
@eaDir) and reformats it.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| music_assistant/providers/filesystem_nfs/provider.py | Implements NFS mount/unmount wrapper around LocalFileSystemProvider. |
| music_assistant/providers/filesystem_nfs/init.py | Provider setup + config entries (host/export path/subfolder/NFS version). |
| music_assistant/providers/filesystem_nfs/constants.py | Defines config keys used by the NFS provider. |
| music_assistant/providers/filesystem_nfs/manifest.json | Registers the new provider (domain/type/stage/docs/icon). |
| music_assistant/providers/filesystem_nfs/icon.svg | Provider icon asset. |
| music_assistant/providers/filesystem_nfs/icon_monochrome.svg | Provider monochrome icon asset. |
| music_assistant/providers/filesystem_local/helpers.py | Updates IGNORE_DIRS to include additional ignored directories. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.