🐛 Traverse reordered while tensors#1936
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Assisted-by: GPT-5.6 via Codex
Assisted-by: GPT-5.6 via Codex
Assisted-by: GPT-5.6 via Codex
burgholzer
force-pushed
the
agent/1910-qtensor-while
branch
from
July 24, 2026 16:08
fbb0e31 to
21a394a
Compare
burgholzer
marked this pull request as ready for review
July 24, 2026 16:27
Signed-off-by: Lukas Burgholzer <burgholzer@me.com>
burgholzer
enabled auto-merge (squash)
July 24, 2026 17:58
burgholzer
disabled auto-merge
July 24, 2026 18:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Summary
TensorIteratorto follow tensor values throughscf.while.instead of assuming positional identity.
value.
entry.
Context
This general SCF/QTensor issue was found while working on loop lowering for the
OpenQASM integration in #1910. It is independent of the frontend and applies to
any pipeline that carries linearly typed quantum tensors through
scf.while.Validation
uvx prek run --from-ref origin/main --to-ref HEADgit diff --check origin/main...HEAD