Repository navigation
Unified timestamp + Unix submenu; add custom formatted copyable date - #347
Merged
mrbuilder1961 merged 6 commits intoSep 28, 2026
Merged
mrbuilder1961 merged 6 commits into
mrbuilder1961 merged 6 commits into
Conversation
This allows different context menu buttons to have the same label, as long as they have a different underlying translatable component (fall back to string equality if its not a translatable component)
JustAlittleWolf
changed the title
Contributor
Author
|
is one way to resolve #299 |
Owner
|
Wow this looks great! A couple of minor notes:
And one more thing while we're on the topic of timestamps - if you could remove the 'Time' part of the Unix translation ('Unix Time' -> 'Unix') that'd be perfect! Thanks again for all your contributions! |
…translation (at least in us english)
Contributor
Author
|
Thanks, both issues have been fixed with the latest commit! |
mrbuilder1961
changed the title
mrbuilder1961
added a commit
that referenced
this pull request
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unifies the "Copy Unix Timestamp" and "Copy Timestamp" options into one "Copy Time" context entry.
Also adds an option to specify the format of an additional context menu entry for time (now the default)
This PR includes a patch for
ContextMenu#get, which used string comparison previously. Due to the button for copying the formatted time having the same label as the button for copying the formatted message, it now instead tries to compare the translatable part of the component (which should be unique for the different options), and falls back to comparing string only, if it is not a translatable component.07_11-16-56_javaw84d.mp4