Fix crash when a small change in progress#108
Open
AddAloner wants to merge 5 commits intomrackwitz:masterfrom
Open
Fix crash when a small change in progress#108AddAloner wants to merge 5 commits intomrackwitz:masterfrom
AddAloner wants to merge 5 commits intomrackwitz:masterfrom
Conversation
Owner
|
Thanks for pointing out the crash. But I'm pretty sure rather the whole calculation further below should be changed, as that seems to be really wrong. -_valueLabelProgressPercentDifference = (progress - self.progress) * 100;
-CFTimeInterval timerInterval = self.animationDuration / ABS(_valueLabelProgressPercentDifference);
+CFTimeInterval timerInterval = self.animationDuration * ABS(progress - self.progress); |
disable MRRotationForStatusBarOrientation in ios extension
|
I got this crash too. @mrackwitz Could you please fix it and release a new version? |
|
Also getting this crash |
|
I did too. I found the error in the code and I added a simple isNan() check. If it is NAN, I set the progress to zero. A proper fix would be nice though. |
jaybowang
added a commit
to jaybowang/MRProgress
that referenced
this pull request
Sep 28, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crash reason in - animateToProgress:
_valueLabelProgressPercentDifference = (progress - self.progress) * 100; // (int) 0
CFTimeInterval timerInterval = self.animationDuration / ABS(_valueLabelProgressPercentDifference); // NaN