Update build to support Java 25 #2238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dependencies and tools to support building on Java 25: * Update Gradle to latest * Update ErrorProne to support latest * Update list of ErrorProne exclusions -- lots of opportunities for future fixes * Fix a Date test that seems inconsistent in current form TBH * Update GitHub Actions to run with Java 25
They run on a older JVM.
Contributor
|
Do we plan to continue supporting Java 11? |
Collaborator
Author
|
No I think we should drop Java 11 but I'm trying to do this one step at a time, the first step IMO is to make it work at all with Java 25. |
Collaborator
Author
|
If anyone has an idea why that one date / time zone tests differs in behavior between 21 and 25 I'd love to hear ideas -- otherwise either we need to track it down or disable that test! |
Contributor
|
I'm not sure why it has changed, but maybe we should just assert on the start of the string rather than the name of the timezone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dependencies and tools to support building on Java 25: