-
Notifications
You must be signed in to change notification settings - Fork 904
make arguments a function prototype property #2222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
903e9e8 to
321fc8e
Compare
|
This confused me for a minute because |
|
@aardvark179 as mentioned in our meeting I spend my whole time hunting for this regression HtmlUnit/htmlunit#1064. My current assumption is a problem with the caller property being visible to some functions because it is NOT defined on the function prototype but instead on every function. The good news: after the move of the 'arguments' property we are a bit more closer to the browsers. And after I have applied this PR to my fork, I was able to change the way the caller property is implemented also (HtmlUnit@88a343c). And with this changes, I got a detailed test suite of 'caller' tests working HtmlUnit/htmlunit-core-js@8769e0e; also some more plain HtmlUnit tests are now passing. Next step is to check with the jenkins folks, if this solves the problem.... but this is something for the next days. |
321fc8e to
08adb55
Compare
|
|
||
| @Override | ||
| void setArguments(Object caller) { | ||
| // todo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is supposed to happen here, that there is a todo for it, I wonder...? 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throw ScriptRuntime.typeErrorById("msg.op.not.allowed");
is called far to many times (i guess), i have to check if we can have it as static function
08adb55 to
b455392
Compare
|
Jenkins is happy with this - HtmlUnit/htmlunit#1064 (comment) |
This is the second step in the arguments refactoring to bring the arguments handling closer to the spec.