Skip to content

Ben/recategorize tests #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ben-c-at-moz merged 12 commits into from
Dec 9, 2025
Merged

Ben/recategorize tests #940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e738e3b
reduce smoke set; run smoke on automanual flow
ben-c-at-moz Dec 5, 2025
b8d16c6
close security issue in CI installer links
ben-c-at-moz Dec 8, 2025
35580c2
update precommit
ben-c-at-moz Dec 8, 2025
53acd9f
Merge branch 'main' into ben/recategorize-tests
ben-c-at-moz Dec 8, 2025
2ad172d
switch headed test for smoke
ben-c-at-moz Dec 8, 2025
0d846ed
default engine dropdown not visible on first page of prefs
ben-c-at-moz Dec 8, 2025
d83d865
minor fixes
ben-c-at-moz Dec 9, 2025
d87adf9
update key
ben-c-at-moz Dec 9, 2025
f72d5d3
Merge branch 'main' into ben/recategorize-tests
ben-c-at-moz Dec 9, 2025
1137250
update key
ben-c-at-moz Dec 9, 2025
72284be
Merge branch 'ben/recategorize-tests' of github.com:mozilla/fx-deskto…
ben-c-at-moz Dec 9, 2025
b578303
update key
ben-c-at-moz Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/l10n.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,10 @@ jobs:
shell: pwsh
- name: Download Executable
if: ${{ inputs.win_installer_link }}
env:
WIN_INSTALLER_LINK: ${{ inputs.win_installer_link }}
run: |
Invoke-WebRequest -Uri ${{ inputs.win_installer_link }} -OutFile "${{ github.workspace }}\setup.exe"
Invoke-WebRequest -Uri $WIN_INSTALLER_LINK -OutFile "${{ github.workspace }}\setup.exe"
New-Item -ItemType Directory -Path "C:\Program Files\Custom Firefox" -Force
shell: pwsh
- name: Install Beta
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,11 @@ jobs:
shell: pwsh
- name: Download Executable
if: ${{ inputs.win_installer_link }}
env:
WIN_INSTALLER_LINK: ${{ inputs.win_installer_link }}
run: |
echo "STARFOX_SPLIT=ci-extended" | Out-File -FilePath .env -Encoding utf8 -Append -Force
Invoke-WebRequest -Uri ${{ inputs.win_installer_link }} -OutFile "${{ github.workspace }}\setup.exe"
echo "STARFOX_SPLIT=smoke" | Out-File -FilePath .env -Encoding utf8 -Append -Force
Invoke-WebRequest -Uri $WIN_INSTALLER_LINK -OutFile "${{ github.workspace }}\setup.exe"
New-Item -ItemType Directory -Path "C:\Program Files\Custom Firefox" -Force
shell: pwsh
- name: Install Beta
Expand Down Expand Up @@ -179,7 +181,7 @@ jobs:
if: ${{ inputs.mac_installer_link }}
run: |
echo "MANUAL='true'" >> "$GITHUB_ENV";
echo "STARFOX_SPLIT=ci-extended" >> .env
echo "STARFOX_SPLIT=smoke" >> .env
echo "Running smoke tests on supplied executable";
- name: Install dependencies
run: |
Expand Down Expand Up @@ -243,7 +245,7 @@ jobs:
MANUAL_DOWNLOAD_LINK: ${{ inputs.linux_tarball_link }}
run: |
echo "MANUAL='true'" >> "$GITHUB_ENV";
echo "STARFOX_SPLIT=ci-extended" >> "$GITHUB_ENV"
echo "STARFOX_SPLIT=smoke" >> "$GITHUB_ENV"
echo "Running smoke tests on supplied executable";
sudo apt install gnome-screenshot
uname -m;
Expand Down
3 changes: 1 addition & 2 deletions choose_ci_set.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,7 @@ def dedupe(run_list: list) -> list:
fh.write("\n".join(ci_paths))
sys.exit(0)

if len(run_list) < MIN_RUN_SIZE:
run_list.extend(ci_paths)
run_list.extend(ci_paths)

# Dedupe just in case
if SLASH == "\\":
Expand Down
Loading
Loading