-
Notifications
You must be signed in to change notification settings - Fork 16
use env to pass input and output parameters #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use env to pass input and output parameters #852
Conversation
ben-c-at-moz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not necessarily opposed to this change, I just don't know what it gets us
|
Hello @ben-c-at-moz , it is a security precaution to make sure that we're properly escaping the input parameters, I don't think the workflow is vulnerable but I thought it wouldn't hurt to apply the fix |
ben-c-at-moz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let's go ahead and merge this. Seems ok.
|
thanks @ben-c-at-moz , I fixed the merge conflict and fixed another input parameter. |
ben-c-at-moz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved, I'm going to merge
Relevant Links
Bugzilla: _
TestRail: _
Description of Code / Doc Changes
use env to pass input and output parameters to prevent attacks from malicious input and dangerous writes, as described in our guidelines.
Process Changes Required
Mark the relevant boxes:
pipenv install)Screenshots or Explanations
If you need to explain your code, do it here.
Comments or Future Work
Do we need to start another PR soon to address something you saw while working on this?
Workflow Checklist
Thank you!