Repository navigation
Conversation
… Perl after every request (~3 ms per request)
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the SizeLimit memory-check optimization.
No open issues 🎉
What changed in this PR
This PR reduces per-request memory-check overhead in the SizeLimit plugin by reading VmSize from /proc/self/status instead of parsing /proc/self/smaps.
Changes:
- Replaces smaps parsing with a lightweight virtual-memory-size reader while preserving the worker shutdown threshold.
- Removes the
Linux::Smaps::Tinydependency. - Adds tests for memory-size reading, threshold behavior, and unavailable measurements.
| File | Description |
|---|---|
t/app-size-limit.t |
Tests memory readings and worker shutdown behavior. |
Makefile.PL |
Removes Linux::Smaps::Tiny from optional prerequisites, retaining BSD::Resource. |
cpanfile |
Removes the Linux::Smaps::Tiny dependency. |
Bugzilla/App/Plugin/SizeLimit.pm |
Reads VmSize from proc status for per-request memory checks. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.