Repository navigation
Bug 2091129 - Bugzilla::DB pings MySQL before every query (about 200 pings per show_bug.cgi request) - #2821
Open
dklawren wants to merge 2 commits into
Open
Bug 2091129 - Bugzilla::DB pings MySQL before every query (about 200 pings per show_bug.cgi request)#2821dklawren wants to merge 2 commits into
dklawren wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the request-scoped database-handle caching change.
No open issues 🎉
What changed in this PR
Reduces repeated database connection checks in Bugzilla by reusing checked handles instead of consulting DBIx::Connector before every query.
Changes:
- Caches database handles per request, rechecking after five seconds, a process ID change, or handle inactivity.
- Adds tests for handle reuse, request boundaries, interval expiry, simulated process ID changes, and reconnection after disconnect.
| File | Description |
|---|---|
t/db-dbh-check.t |
Tests connection-check frequency and handle revalidation. |
Bugzilla/DB.pm |
Replaces delegated handle access with request-scoped caching and periodic checks. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.