Package bumps#295
Open
LeonHuston wants to merge 1 commit into
Open
Conversation
pkqk
reviewed
Feb 10, 2025
| "go.opentelemetry.io/otel/sdk/resource" | ||
| sdktrace "go.opentelemetry.io/otel/sdk/trace" | ||
| semconv "go.opentelemetry.io/otel/semconv/v1.25.0" | ||
| semconv "go.opentelemetry.io/otel/semconv/v1.26.0" |
Member
There was a problem hiding this comment.
@LeonHuston is this the package that needs to be kept in sync elsewhere? I remember it causing services to not start up?
Contributor
Author
There was a problem hiding this comment.
Yep, thats why theres that small test in telemetry_test.go which fails if you revert this diff. Will do another check to make sure that test is sufficient to catch this case
LeonHuston
force-pushed
the
package-upgrades
branch
from
23cf109 to
f2fff65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have left the packages alone for a little bit so this is just here to bump some of them, trims the dep tree a bit which is quite nice