Skip to content

Use ! in place of not keyword for Pilz and CHOMP planners (backport #3217) #3222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sea-bass merged 1 commit into from
Jan 10, 2025
Merged

Use ! in place of not keyword for Pilz and CHOMP planners (backport #3217) #3222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion moveit_planners/chomp/chomp_motion_planner/src/chomp_planner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ void ChompPlanner::solve(const planning_scene::PlanningSceneConstPtr& planning_s
res.processing_time[0] = std::chrono::duration<double>(std::chrono::system_clock::now() - start_time).count();

// report planning failure if path has collisions
if (not optimizer->isCollisionFree())
if (!optimizer->isCollisionFree())
{
RCLCPP_ERROR(getLogger(), "Motion plan is invalid.");
res.error_code.val = moveit_msgs::msg::MoveItErrorCodes::INVALID_MOTION_PLAN;
Expand Down
2 changes: 1 addition & 1 deletion ...anners/pilz_industrial_motion_planner/include/joint_limits_copy/joint_limits_rosparam.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ namespace
template <typename T>
void declareParameterTemplate(const rclcpp::Node::SharedPtr& node, const std::string& name, T default_value)
{
if (not node->has_parameter(name))
if (!node->has_parameter(name))
{
node->declare_parameter<T>(name, default_value);
}
Expand Down