Skip to content

Use go.uber.org/goleak to test for zstd goroutine leaks #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mostynb wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use go.uber.org/goleak to test for zstd goroutine leaks #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ require (
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/kr/pretty v0.3.0 // indirect
github.com/pmezard/go-difflib v1.0.0 // indirect
go.uber.org/goleak v1.3.0 // indirect
golang.org/x/net v0.51.0 // indirect
golang.org/x/sys v0.41.0 // indirect
golang.org/x/text v0.34.0 // indirect
Expand Down
2 changes: 2 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ go.opentelemetry.io/otel/sdk/metric v1.39.0 h1:cXMVVFVgsIf2YL6QkRF4Urbr/aMInf+2W
go.opentelemetry.io/otel/sdk/metric v1.39.0/go.mod h1:xq9HEVH7qeX69/JnwEfp6fVq5wosJsY1mt4lLfYdVew=
go.opentelemetry.io/otel/trace v1.39.0 h1:2d2vfpEDmCJ5zVYz7ijaJdOF59xLomrvj7bjt6/qCJI=
go.opentelemetry.io/otel/trace v1.39.0/go.mod h1:88w4/PnZSazkGzz/w84VHpQafiU4EtqqlVdxWy+rNOA=
go.uber.org/goleak v1.3.0 h1:2K3zAYmnTNqV73imy9J1T3WC+gmCePx2hEGkimedGto=
go.uber.org/goleak v1.3.0/go.mod h1:CoHD4mav9JJNrW/WLlf7HGZPjdw8EucARQHekz1X6bE=
golang.org/x/net v0.51.0 h1:94R/GTO7mt3/4wIKpcR5gkGmRLOuE/2hNGeWq/GBIFo=
golang.org/x/net v0.51.0/go.mod h1:aamm+2QF5ogm02fjy5Bb7CQ0WMt1/WVM7FtyaTLlA9Y=
golang.org/x/sys v0.41.0 h1:Ivj+2Cp/ylzLiEU89QhWblYnOE9zerudt9Ftecq2C6k=
Expand Down
8 changes: 6 additions & 2 deletions internal/zstd/zstd_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ import (
"google.golang.org/grpc/encoding"
"google.golang.org/grpc/test/bufconn"

"go.uber.org/goleak"

"github.com/mostynb/go-grpc-compression/internal/testserver"
)

Expand All @@ -43,6 +45,7 @@ const (
)

func TestRegisteredCompression(t *testing.T) {
defer goleak.VerifyNone(t)
clobbering := true
PretendInit(clobbering)

Expand Down Expand Up @@ -71,6 +74,7 @@ func TestRegisteredCompression(t *testing.T) {
}

func TestRoundTrip(t *testing.T) {
defer goleak.VerifyNone(t)
clobbering := true
PretendInit(clobbering)

Expand Down Expand Up @@ -101,9 +105,9 @@ func TestRoundTrip(t *testing.T) {
grpc.WithDefaultCallOptions(grpc.UseCompressor(Name)),
grpc.WithTransportCredentials(insecure.NewCredentials()))
require.NoError(t, err)
t.Cleanup(func() {
defer func() {
assert.NoError(t, conn.Close())
})
}()

client := testserver.NewTestServerClient(conn)
resp, err := client.SendMessage(context.Background(), &testserver.MessageRequest{Request: message})
Expand Down