Skip to content

Clarify sitemap lastModified timestamp approach - no changes needed - #6

Closed
mostlyerror with Copilot wants to merge 1 commit into
seo-phase-1-technical-foundationfrom
copilot/sub-pr-5
Closed

mostlyerror with Copilot wants to merge 1 commit into
seo-phase-1-technical-foundationfrom
copilot/sub-pr-5

Conversation

Copilot AI commented Jan 10, 2026

Copy link
Copy Markdown

Addressed question about using new Date() for sitemap timestamps vs static dates.

Analysis

For static export sites (output: 'export'), sitemap generates once at build time. Using new Date() is appropriate because:

  • Each deployment is a fresh build - timestamp reflects reality
  • Search engines treat lastModified as a hint, not a directive
  • changeFrequency fields (monthly/weekly) provide the primary crawl guidance
  • No cache invalidation concerns for small static XML files

Conclusion

Current implementation is correct. Initial review feedback was overly cautious and didn't account for the static deployment model.

// Current approach - appropriate for static builds
{
  url: baseUrl,
  lastModified: new Date(),  // ✓ Accurate for build-time generation
  changeFrequency: 'monthly',
  priority: 1,
}

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@vercel

vercel Bot commented Jan 10, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
goodrobotco.com Ready Ready Preview, Comment Jan 10, 2026 8:01pm

Copilot AI changed the title [WIP] Update timestamp generation for SEO improvements Clarify sitemap lastModified timestamp approach - no changes needed Jan 10, 2026
Copilot AI requested a review from mostlyerror January 10, 2026 20:02
@mostlyerror

Copy link
Copy Markdown
Owner

@copilot there's nothing to merge or review here right? I can close this PR?

Copilot AI commented Jan 10, 2026

Copy link
Copy Markdown
Author

@copilot there's nothing to merge or review here right? I can close this PR?

Correct - this PR has no code changes. I clarified that the current new Date() implementation in sitemap.ts is appropriate for your static export deployment. You can close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants