Repository navigation
馃悰 fix: a rebased landing names its commit, and a landed task reads landed - #32
Merged
Merged
Conversation
The runner writes the landing file before the lane ever rebases, naming the attempt's work commit, and a rebase replays the file unchanged while giving that commit a new sha, so the record named a commit no branch holds (bloomery T-0270). After a rebase onto a moved base, each replayed landing file now names its work commit's new sha, the parent of the commit that added it, and the rebased tip is amended to carry that. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EabbhASMvWNhC7x4K9NJMF
The state machine ends a candidate at ready and records its landing beside it, so the board and torve status showed tasks that landed weeks ago as still waiting to land. Both now show landed for a ready task whose landing the board, the lane or the tree records; the state machine is unchanged, and the board's document-wait set reads the same helper. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EabbhASMvWNhC7x4K9NJMF
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EabbhASMvWNhC7x4K9NJMF
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two engine defects from the 0.2 list. Both break an existing promise, so they ship as fixes rather than a design document.
1. A rebased landing names the commit that landed (
lane.py). Source:a-rebased-landing-records-the-pre-rebase-commit, from bloomery T-0270._land_rebasedand_rebase_document,_restate_landingspoints each replayed landing file at its work commit's new sha, which is the parent of the commit that added the file. The rebased tip is then amended to carry the change. Fast-forward landings are untouched.git rebasedidn't already.2. A landed candidate reads
landed, notready(projections.py,cli/manager.py).readyand records its landing only beside it. Sotorve statusandmanager boardshowed landed tasks as ready, for days.projections.landed_idscollects landed tasks from three sources: the board'slanded_sha, the lane's landings, and landings shipped in the tree.statusandmanager boardshowlandedfor any ready task in that set, in text and JSON._document_waitsnow uses the same helper.landedas astatevalue.Tests:
spec checkare clean.The third commit closes the source with "Fixed at 8b9d337". I'll correct that sha to the squash commit after merge, as with #4.
馃 Generated with Claude Code
https://claude.ai/code/session_01EabbhASMvWNhC7x4K9NJMF