bugfix: Is should return false when called without codes#59
Open
UmarFarooq-MP wants to merge 1 commit intomonzo:masterfrom
Open
bugfix: Is should return false when called without codes#59UmarFarooq-MP wants to merge 1 commit intomonzo:masterfrom
UmarFarooq-MP wants to merge 1 commit intomonzo:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58
This change ensures that calling Is(err) without passing any code arguments returns false. Previously Is(err) would always return true, because PrefixMatches treats empty code as a match.
The fix adds an early guard
if len(code) == 0 { return false }at the start of Is. New tests have been added to assert this behavior, including nested/unwrapped errors. All existing tests continue to pass.