Repository navigation
Conversation
Words creates its own registry; Word and line breaks register through a prop, the layout hands the caret the word element. Only the overflow check is exported. LETTER_SELECTOR moves to the test page's selectors module. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…admap Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #8563 (T3): base is
refactor/caret-boundary, retarget to master once that merges.Summary
Roadmap T4: the word registry becomes private to Words. Only the overflow check stays exported.
caret.goTo({ wordIndex, + wordEl: registry.getWord(wordIndex), // the layout passes the element })wouldActiveWordOverflow(used bybefore-insert-text) reads the registry of the mounted Words, and returnstruewhen none is mounted.Evidence
word-registry.spec.tscovers the guard that keeps a remount's element when the old one's cleanup runs after it.words-wrapper-height.specbuilds its own registry. The twoWords.spectests that read the global registry are gone; the existing rendered-output tests cover the same cases.__mt.checkLayout()):[]after load, line jumps, tape mode (letter) with the pace caret on, and 25 extra letters. Caret offset 2–4px.Merge Danger
Door: two-way
Internal refactor; reverting restores the global module.
Blast Radius: test-words
No visible change. The caret position, the line jump, the tape scroll and the extra-letter overflow block all read through the new registry, so a miss there shows up as a stuck caret or a wrapping word.
🤖 Generated with Claude Code