feat: add Chinese Traditional 1k, 5k, 10k, and 50k word lists (@nota-noob)#7479
feat: add Chinese Traditional 1k, 5k, 10k, and 50k word lists (@nota-noob)#7479nota-noob wants to merge 18 commits intomonkeytypegame:masterfrom
Conversation
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
There was a problem hiding this comment.
Pull request overview
Adds additional Traditional Chinese (zh-Hant) word list variants to the shared language schema and the frontend language group list, plus new static language JSON assets to back those options.
Changes:
- Extend
LanguageSchemato includechinese_traditional_{1k,5k,10k,50k}. - Add the new Traditional Chinese variants to the
chineselanguage group for UI selection. - Add new language asset files for
chinese_traditional_1kandchinese_traditional_5k.
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/schemas/src/languages.ts | Adds new Traditional Chinese language enum values so they’re recognized/validated across the app. |
| frontend/src/ts/constants/languages.ts | Adds the new Traditional Chinese variants to the chinese group so they appear in UI groupings. |
| frontend/static/languages/chinese_traditional_1k.json | New 1k Traditional Chinese word list asset. |
| frontend/static/languages/chinese_traditional_5k.json | New 5k Traditional Chinese word list asset. |
| "除了", | ||
| "企業", | ||
| "終於", | ||
| "總統", |
There was a problem hiding this comment.
Duplicate word in list: "總統" appears multiple times in this file; frontend/scripts/check-assets.ts flags even 1 duplicate. Remove duplicates / regenerate list with unique entries.
| "總統", |
| "重大", | ||
| "之中", | ||
| "人才", | ||
| "總統", |
There was a problem hiding this comment.
Same duplicate as above: "總統" is repeated (already listed earlier). Dedupe list to satisfy assets validation.
| "總統", | |
| "領袖", |
| "chinese_traditional_1k", | ||
| "chinese_traditional_5k", | ||
| "chinese_traditional_10k", |
There was a problem hiding this comment.
PR description mentions chinese_traditional_6k.json, but schema/group add chinese_traditional_5k instead. Either update description or rename/add the intended 6k list to match.
|
hi @nota-noob , thank you for your contribution. Could you add the bcp47 property to the existing https://github.com/monkeytypegame/monkeytype/blob/master/frontend/static/languages/chinese_traditional.json as well? |
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
Use the simplified to traditional pipeline for 1k as well (had only used for 5k, 10k, 50k)
Description
This pr adds support for additional word lists for the Traditional Chinese language.
Checks
packages/schemas/src/languages.tsfrontend/src/ts/constants/languages.tsfrontend/static/languagespackages/schemas/src/themes.tsfrontend/src/ts/constants/themes.tsfrontend/static/themespackages/schemas/src/layouts.tsfrontend/static/layoutsfrontend/static/webfontspackages/schemas/src/fonts.tsfrontend/src/ts/constants/fonts.tsCloses #