fix(caps-warning): caps warning is inverted when caps is active on page load (@fehmer, @Leonabcd123) #7478
+53
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leonabcd123
changed the title
|
This works, but it does reintroduce internal inversion for Linux CapsLock events. Conceptually, the issue on Linux is timing (modifier state not settled at event time), not that getModifierState("CapsLock") is incorrect. A deferred read would avoid platform-specific inversion and keep CapsLock state fully derived from OS state. Might be worth considering if we want to avoid encoding Linux timing assumptions into logic long-term. |
This reverts commit f29ffd4.
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update caps state on keydown rather than keyup
Fixes #7472