Follow-up to #8: Add floating inline clip previews#28
Draft
alvst wants to merge 5 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency
This draft builds on #8 (Add configurable clip previews). Its current diff intentionally includes #8 because GitHub cannot use a branch in this fork as the base of an upstream PR.
After #8 merges, this branch will be rebased onto upstream
main; this PR will then show only the floating-preview follow-up.What changed
Why
The first inline-preview implementation resized and rendered inside the Pesty bar, which made the quick view feel like part of the strip rather than an independent preview. The floating panel gives the preview its own visual space and keeps navigation stable.
Validation
swift build -c release --arch arm64 --arch x86_64swift build -c release --arch arm64 --arch x86_64 -Xswiftc -DMASScreenshots
Demo mode; Pesty window only.