fix: show all registry accounts in deployment when provider is not auto-detected#1189
Closed
litlmike wants to merge 1 commit intomoghtech:mainfrom
Closed
fix: show all registry accounts in deployment when provider is not auto-detected#1189litlmike wants to merge 1 commit intomoghtech:mainfrom
litlmike wants to merge 1 commit intomoghtech:mainfrom
Conversation
… determined When a deployment's image doesn't contain a registry domain prefix (or no image is set yet), the account selector previously defaulted to filtering by 'docker.io', hiding accounts from other registries like ghcr.io or quay.io. Now when the provider cannot be auto-detected from the image name or build configuration, all available registry accounts are shown instead of only docker.io accounts. The provider is still auto-detected when possible: - Image type: extracted from image name (e.g., ghcr.io/org/repo) - Build type: taken from the build's first image registry domain Closes moghtech#1058
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1058 — non-docker.io registry accounts (e.g., ghcr.io, quay.io) were not shown in the Deployment Image account selection.
Problem
When configuring a deployment's image registry account, the account selector auto-detects the registry provider from the image name. If the provider couldn't be determined (no image set yet, or image without a domain prefix), it defaulted to
docker.io, filtering out all non-docker.io accounts.This meant users who only configured registries like ghcr.io saw an empty account list.
Fix
provideroptional inAccountSelectorandAccountSelectorConfigundefined, show accounts from all registries instead of onlydocker.io?? "docker.io"fallback in deployment configProvider auto-detection still works when possible:
ghcr.io/org/repo→ghcr.io)Files Changed
frontend/src/components/config/util.tsx— make provider optional, skip domain filter when unsetfrontend/src/components/resources/deployment/config/index.tsx— pass provider as-is without docker.io fallback