feat(testing): add observability smoke checks for metrics, logs, traces, and dashboards - #1660
Open
AdityaShome wants to merge 2 commits into
Open
feat(testing): add observability smoke checks for metrics, logs, traces, and dashboards#1660AdityaShome wants to merge 2 commits into
AdityaShome wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR strengthens the observability validation path by fixing metrics exporter startup in the monitoring dashboard example and hardening smoke checks for clearer diagnostics and deterministic Jaeger trace validation.
It keeps the current demo dashboard behavior, but ensures

/metricsis reliably populated and makes the stack checks easier to debug when something is not ready.Execution Flow
flowchart TD A["Start monitoring app"] B["Start observability stack"] C["Run smoke_check.sh"] A --> A1["Prime and start exporter"] A1 --> A2["metrics endpoint ready"] B --> B1["Prometheus healthy"] B --> B2["Loki ready"] B --> B3["Jaeger ready"] C --> C1["Check metrics families"] C --> C2["Check Prometheus queries"] C --> C3["Check Loki logs"] C --> C4["Inject and verify Jaeger trace"] A2 --> C1 B1 --> C2 B2 --> C3 B3 --> C4 C1 --> D["Smoke check passed"] C2 --> D C3 --> D C4 --> DWhat Changed
1) Prime/start Prometheus exporter in dashboard example
examples/monitoring_dashboard/src/main.rsbuild_router(), the example now:refresh_once().awaitto prime the cached metrics payload/metricsoutput during startup and improves scrape reliability.2) Enable Zipkin collector explicitly in Jaeger service
ops/observability/docker-compose.ymlCOLLECTOR_ZIPKIN_HOST_PORT=:9411/api/v2/spans) is available consistently.3) Improve smoke check observability and failure messaging
ops/observability/smoke_check.shValidation Performed
cargo check --manifest-path examples/monitoring_dashboard/Cargo.tomlpassed.bash -n ops/observability/smoke_check.shpassed./metricsfamily checksNotes
examples/monitoring_dashboard/src/main.rs.