fix: remove space in FATAL match and use project_root for .env path - #1655
Open
PrinceGautam2106 wants to merge 2 commits into
Open
PrinceGautam2106 wants to merge 2 commits into
PrinceGautam2106 wants to merge 2 commits into
Conversation
Handle FATAL-prefixed log lines without requiring surrounding spaces and add a regression test. Made-with: Cursor
Author
|
Hello @lijingrs @yangrudan |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Problem
Fixes two bugs: FATAL log lines without surrounding spaces were not
colorized red, and the .env file was saved to the current working
directory instead of the project root.
2. Changes
crates/mofa-cli/src/commands/agent/logs.rs: Removed extra spaceinside
"FATAL"string soFATAL:prefixed lines are correctlycolorized red
mofa/commands/vibe.py: Changedos.getcwd()toproject_rootso.envis always saved in the correct project location