test: read the db clock with scalar_one so ty accepts it under sqlalchemy 2.1 - #193
Merged
Merged
Conversation
Benchmark gate✅ gate passed
Gated (fails the build): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the red
lintleg of the scheduled dependency check (run 36128642533).SQLAlchemy 2.1.0 retyped
Result.scalar()fromAnytoOptional[_T], so ty 0.0.84 reportsAny | None + timedeltaintest_mark_pending_with_lease_uses_db_clock.SELECT clock_timestamp()always returns exactly one row, soscalar_one()states the real contract and is what thenext_atread two lines below already uses.Test-only; no floor or cap change. Verified:
just lint-cigreen on sqlalchemy 2.0.54 and 2.1.0;tests/test_integration.py89 passed against Postgres.