Repository navigation
Conversation
0.2.0-alpha.11 added the json-schema-2020-12-preservation client scenario. The conformance client does not handle it and exits with "Unsupported conformance scenario", so both client suites fail on it once CI moves past alpha.10. Handle the scenario as it asks: list tools, then send the inputSchema of json_schema_2020_12_tool back through json_schema_echo. rmcp keeps every keyword the scenario checks. Bump CONFORMANCE_VERSION to alpha.12.
DaleSeo
previously approved these changes
Oct 10, 2026
DaleSeo
left a comment
Member
There was a problem hiding this comment.
Thanks @SergeevDmitry! Left a minor comment.
The json_schema_echo result was dropped, so a tool-level error still let the client exit 0. Check is_error so local runs fail loudly.
DaleSeo
approved these changes
Oct 10, 2026
DaleSeo
approved these changes
Oct 10, 2026
DaleSeo
left a comment
Member
There was a problem hiding this comment.
Thanks for the quick fix, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the conformance suite from
0.2.0-alpha.10to0.2.0-alpha.12and adds the one client scenario the conformance client does not handle yet.Motivation and Context
0.2.0-alpha.11(2026-08-07) added thejson-schema-2020-12-preservationclient scenario (modelcontextprotocol/conformance#335). It is in theallsuite for both 2025-11-25 and 2026-07-28.conformance-clienthas no arm for it and exits withUnsupported conformance scenario, so on alpha.11 or alpha.12 both client suites fail it:The new arm does what the scenario asks:
conformance_lifecycle();inputSchemaofjson_schema_2020_12_toolback throughjson_schema_echoas{ "schema": ... }.rmcp keeps every keyword the scenario checks:
$schema,$defs,additionalProperties,allOf/anyOf,if/then/else, and$anchor.How Has This Been Tested?
I ran every step of
conformance.ymllocally withnpx @modelcontextprotocol/conformance@0.2.0-alpha.12, on macOS arm64 with stable Rust 1.99.mainexpected-failures-extensions.yamlextensionssuite againstexpected-failures-extensions.yamlThe server binary does not change in this PR, so its two columns are the same run.
json-schema-2020-12-preservationalone: 9/9 on both spec versions.cargo clippy -p mcp-conformance --all-targets -- -D warningsis clean.cargo test -p mcp-conformancepasses.expected-failures-extensions.yamlneeds no change.Breaking Changes
None. Only the conformance client and CI change.
Types of changes
Checklist
Additional context
The arm returns an error if
json_schema_2020_12_toolis not listed, so a change to the scenario shows up as a failed run instead of a silent pass.AI assistance: I used Claude Code to help write this change.