Repository navigation
fix: support nested MCP header property paths - #1111
Open
nolankhoingo wants to merge 1 commit into
Open
nolankhoingo wants to merge 1 commit into
nolankhoingo wants to merge 1 commit into
Conversation
github-actions
Bot
added
T-core
DaleSeo
reviewed
Aug 3, 2026
Comment on lines
+223
to
+229
| fn contains_annotation(value: &Value) -> bool { | ||
| match value { | ||
| Value::Object(object) => { | ||
| object.contains_key("x-mcp-header") || object.values().any(contains_annotation) | ||
| } | ||
| Value::Array(values) => values.iter().any(contains_annotation), | ||
| _ => false, |
Member
There was a problem hiding this comment.
How could this distinguish subschemas from ordinary JSON values so that something like default: {"x-mcp-header":"literal"} does not cause a valid tool to be rejected?
Contributor
|
This pull request has had no activity for 60 days and is now marked as stale. It will be closed in 14 days if there is no further activity. Add the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
MCP 2026-07-28 permits statically reachable primitive annotations under plain properties chains. The current top-level-only cache rejects otherwise valid tools.
Specification: https://modelcontextprotocol.io/specification/2026-07-28/basic/transports/streamable-http
Validation
cargo test -p rmcp --lib --features client,transport-streamable-http-client,server-side-http transport::common::mcp_headers::tests
All 36 focused header tests pass.