Repository navigation
Conversation
Fixes modelcontextprotocol#156: passing errlog (default sys.stderr) directly as the subprocess stderr target breaks in Jupyter, where sys.stderr has no fileno (UnsupportedOperation: fileno), swallowing all server diagnostics. The server's stderr is now always a pipe, and a reader task forwards it to errlog, so fileno-less streams work. Writes go through anyio.to_thread to keep blocking I/O off the loop.
|
This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #156. If a maintainer assigns you to #156, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take. You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way. CONTRIBUTING.md has the full reasoning, but in short:
Maintainers: reopen, remove |
Fixes #156: passing errlog (default sys.stderr) directly as the subprocess stderr target breaks in Jupyter, where sys.stderr has no fileno (UnsupportedOperation: fileno), swallowing all server diagnostics. The server's stderr is now always a pipe, and a reader task forwards it to errlog, so fileno-less streams work.
Writes go through anyio.to_thread to keep blocking I/O off the loop.
Fixes #
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
help wanted, or I'm a maintainer)Additional context