Conversation
mstockm
reviewed
Nov 14, 2019
mstockm
left a comment
There was a problem hiding this comment.
Awesome work! One question which @laughinghan and I had earlier which we should figure out, is if we want to add some code to set the default theme to match the older version (in the screenshot it appears to have the new default theme). This would mean not changing the visual appearance of existing charts. Also I can help out with testing a build of this using a non-hotloaded installation if you haven't done that already
kariapriyank
pushed a commit
that referenced
this pull request
Feb 28, 2025
Update _streamline.py to avoid np.matrix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: https://github.com/mode/issues/issues/663
This PR consists of modifications to Plotly release v4.1.0 for use in Mode's own Python notebook environment. The general workflow was to mimic changes made to the 3.2.1 release for use in Mode's notebooks (master...mode-plotly-3.2.1-layed#diff-3465b0f2dbd6f036db2c0713d3f40872R112).
We created a mock report with the following SQL query:
And tested it in a Python notebook with this:
This example code was based on this report: https://app.mode.com/editor/modeanalytics/reports/834ec095fc72/notebook