Add basic repo structure #1
Conversation
austinvazquez
force-pushed
the
jumpstart-repo
branch
3 times, most recently
from
70f2705 to
41319c0
Compare
|
Fork PR which ran the GitHub Actions checks since this is the first PR. |
| test: CMD=go test -v ./... | ||
| test: foreach | ||
|
|
||
| .PHONY: help |
There was a problem hiding this comment.
We should also have a look at a step to run and to validate go generate for the seccomp default.json to make sure it matches the code.
We may have something in moby that did this, but probably wouldn't be too complicated.
There was a problem hiding this comment.
Did a quick copy/paste to test this. I gutted most of what we had in moby; it's small enough now should I go through the work to preserve history. Thoughts?
|
|
||
| ## License | ||
|
|
||
| This project is licensed under the Apache License 2.0. See [LICENSE](LICENSE) for details. |
There was a problem hiding this comment.
We still need to add proper license headers to our code (also other projects); I like the approach some projects took with just the SPDX headers and a 1-line copyright (can be multiple), but I need to dig up some research I did on correctness; https://github.com/google/oss-rebuild/blob/6f57c474a8faf3012204792af8ef5d8b6fae2fd1/cmd/proxy/main.go#L2
There was a problem hiding this comment.
Taking a look at this more. The spdx header seems straightforward. The question I have is how much of the copyright/notice needs to be preserved from moby/moby versus can I apply a Moby project authors copyright on top?
austinvazquez
force-pushed
the
jumpstart-repo
branch
3 times, most recently
from
95eead1 to
b31b031
Compare
Signed-off-by: Austin Vazquez <[email protected]>
Signed-off-by: Austin Vazquez <[email protected]>
Signed-off-by: Austin Vazquez <[email protected]>
Signed-off-by: Austin Vazquez <[email protected]>
Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
jumpstart-repo
branch
from
b31b031 to
65052cf
Compare
Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
jumpstart-repo
branch
from
65052cf to
8fb220c
Compare
| - name: Install ltag | ||
| run: go install github.com/containerd/ltag@latest | ||
|
|
||
| - name: Run file header checks | ||
| run: ltag --check -t "./script/validate/template" -v |
There was a problem hiding this comment.
Reused the mechanism I've used in containerd and other projects for file header checks unless there is a more preferred option?
2 participants
Build out some of the repository boilerplate. e.g. README, gitignore, basic GitHub Actions, etc.