[Kafka]: Add configuration support#256
Merged
shay79il merged 1 commit intomlrun:developmentfrom Feb 12, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds additional Helm chart flexibility for Kafka listener configuration, while also updating network egress rules and bumping the chart version.
Changes:
- Add optional per-listener
configurationsupport to the Strimzi Kafka CR template. - Extend the Kafka RBAC NetworkPolicy egress rules to allow traffic to a
registrynamespace (ports 5000/80). - Bump chart version from
0.11.0-rc6to0.11.0-rc7.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
charts/mlrun-ce/templates/kafka/kafka-network-policy.yaml |
Adds registry-related egress rules to the Kafka access NetworkPolicy. |
charts/mlrun-ce/templates/kafka/kafka-cluster.yaml |
Allows passing listener-specific Strimzi configuration blocks from values. |
charts/mlrun-ce/Chart.yaml |
Chart version bump to reflect changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fcb43f3 to
ec05fe6
Compare
GiladShapira94
approved these changes
Feb 12, 2026
f70ee42 to
ec05fe6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
kafka-cluster.yaml -
Add configuration block support
Added rendering of the configuration block for Kafka listeners,
enabling nodePort and advertisedHost settings via Helm values.
kafka-network-policy.yaml - Targeted Kafka isolation
Before:
Default-deny egress policy requiring whitelist for every service (DNS, API server, registry, etc.)
After:
Targeted isolation that:
Restricts Kafka ports (9092-9094) to designated namespace only
Allows all other egress traffic without explicit whitelist
Renamed from allow-kafka-access to kafka-isolation
JIRA