Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #468 +/- ##
==========================================
+ Coverage 79.30% 79.33% +0.02%
==========================================
Files 5 5
Lines 3929 3929
Branches 1311 1311
==========================================
+ Hits 3116 3117 +1
+ Misses 295 294 -1
Partials 518 518 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a tab separates the opening code fence from its info string, the info string keeps the tab and the language is lost:
The spec says the text after the fence "is trimmed of leading and trailing spaces or tabs and called the info string" (4.5), so commonmark.js gives
<pre><code class="language-ruby">.md_setup_fenced_code_detail()only skipped spaces, sodet->infostarted with the tab, and thedet->langscan stopped right away at that whitespace, which left an empty language. A trailing tab ended up indet->infothe same way.The fix trims with
ISBLANK()(space or tab) on both ends.md_is_opening_code_fence()doesn't need a change since it only looks for the end of the line and for backticks.I added a "Tabs around the fenced code info string" section to
test/regressions.txt, with a tab before the info string and a mix of spaces and tabs on both sides. Both examples fail without the change.spec.txt,coverage.txt,regressions.txtand thespec-*.txtsuites all pass with md2html built from this branch.