Install drjit-core headers without JIT - #527
Open
jeongseok-meta wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Header-only Dr.Jit installations currently omit the public
drjit-coreheaders when every JIT backend is disabled. Public Dr.Jit headers include files such asdrjit-core/half.handdrjit-core/jit.h, so the installed header set is incomplete in that configuration.The missing-target guard and C++ library destinations are intentionally handled separately in #519. This PR corresponds to conda-forge's
0001-Install-drjit-core-headers.patch. Once this change is included in an upstream release, the feedstock can remove that patch.Changes
drjit-coreheaders whenever the top-level Dr.Jit project is installed.nanothreadheaders conditional on JIT support.This PR does not change target installation or library destinations; those changes remain in #519.
Testing
git diff --checkCMAKE_PROJECT_INCLUDEto isolate the unrelated missing-target issue handled by Fix CMake installs for C++-only builds #519.85b86aa8negative control omittedinclude/drjit-core/half.h; this branch installedinclude/drjit-core/half.handinclude/drjit-core/macros.h.find_package(drjit)consumer built and passed the installed-headerhalf_smoketest.