Skip to content

HTML Export Support#1689

Merged
Amndeep7 merged 33 commits intomainfrom
htmlConverter
Apr 16, 2026
Merged

HTML Export Support#1689
Amndeep7 merged 33 commits intomainfrom
htmlConverter

Conversation

@charleshu-8
Copy link
Copy Markdown
Contributor

@charleshu-8 charleshu-8 commented Aug 17, 2023

  • Add support for an hdf2html convert command to generate HTML exports via HTML export feature from HDF Converters

@charleshu-8
Initial converter
8fb223b 
Signed-off-by: Charles Hu <chu@mitre.org>
@charleshu-8 charleshu-8 added the enhancement New feature or request label Aug 17, 2023
@charleshu-8 charleshu-8 self-assigned this Aug 17, 2023
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 25, 2023 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Amndeep7 Amndeep7 marked this pull request as ready for review December 20, 2023 06:49
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 20, 2023 •
edited
Loading

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Amndeep7 Amndeep7 added the ready-to-merge Used by mergify to identify if a PR is ready to merge into main. label Dec 20, 2023
Amndeep7
Amndeep7 requested changes Dec 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Amndeep7 Amndeep7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests (here and in hdf-converters), needs to be documented in the readme

@Amndeep7 Amndeep7 removed the ready-to-merge Used by mergify to identify if a PR is ready to merge into main. label Dec 20, 2023
@Amndeep7 Amndeep7 mentioned this pull request Mar 6, 2024
Merged
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarCloud

@em-c-rod
Copy link
Copy Markdown
Contributor

em-c-rod commented Apr 1, 2024

Needs comments added in README

em-c-rod
em-c-rod reviewed Apr 1, 2024
View reviewed changes
Comment thread src/commands/convert/hdf2html.ts Outdated
em-c-rod
em-c-rod reviewed Apr 1, 2024
View reviewed changes
Comment thread tailwind.config.js Outdated
kemley76 added 5 commits June 10, 2024 13:04
@kemley76
Merge branch 'main' into htmlConverter
699544d
@kemley76
fix hdf2html conversion
ba03e25 
Signed-off-by: kemley76 <kemley@mitre.org>

Signed-off-by: kemley76 <kemley@mitre.org>
@kemley76
added tests for hdf2html
171600f 
Signed-off-by: kemley76 <kemley@mitre.org>
@kemley76
update README
cebb918 
Signed-off-by: kemley76 <kemley@mitre.org>

Signed-off-by: kemley76 <kemley@mitre.org>
@kemley76
Merge branch 'main' into htmlConverter
aee3cc3
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jun 11, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kemley76 kemley76 mentioned this pull request Jun 11, 2024
Closed
@kemley76
Copy link
Copy Markdown
Contributor

kemley76 commented Jun 11, 2024

These changes are dependent on this Heimdall PR

kemley76 added 3 commits July 17, 2024 10:43
@kemley76
update test after hdf2html updates
93314d9 
Signed-off-by: Kaden Emley <kemley@mitre.org>
@kemley76
Merge branch 'main' into htmlConverter
3f9993d
@kemley76
update hdf2html tests to ignore autogenerated tailwind css
40c3c8a 
Signed-off-by: Kaden Emley <kemley@mitre.org>
@kemley76
Copy link
Copy Markdown
Contributor

kemley76 commented Jul 26, 2024

Now dependent on only this heimdall PR

@kemley76
only remove versions when running hdf2html tests
8f43bbc 
Signed-off-by: Kaden Emley <kemley@mitre.org>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 26, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kemley76 kemley76 mentioned this pull request Aug 16, 2024
Closed
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 3, 2025

This pull request has a conflict. Could you fix it @charleshu-8?

Amndeep7 added 11 commits April 10, 2026 07:08
@Amndeep7
merge
da84e42 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7
rework test to match the new style
5312ea7 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7
lint
cacfa56 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7
async needs to be there
0b4549e 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7
there's some weird performance issue going on with the mapper that i …
372ef8a 
…need to look into. don't think this is good to merge yet.

Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7
Merge branch 'main' into htmlConverter
bce2082
@Amndeep7
copy over sample files from the monorepo or regenerate them as necessary
7e4b444 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7
i dunno why we were git ignoring html files but we should allow them
c5ae152 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7
update integration to match modern standards and also use the latest …
ddcf056 
…version of the mapper

Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7
reenable tests that had been too slow - it might still take ages now …
af397a5 
…but it definitely should be fast enough once the monorepo release is out

Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7
documentation update to match the option having the right case from t…
48f3fe7 
…he getgo

Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7
Copy link
Copy Markdown
Contributor

Amndeep7 commented Apr 15, 2026

This is good to go. I think I'd like to wait for the monorepo release with the performance improvements before merging just cause i'm worried about the windows e2e tests taking ages for some reason.

Amndeep7 added 3 commits April 15, 2026 23:45
@Amndeep7
fix a typo in a function name and add a new util function to normaliz…
e715861 
…e newlines which was impacting the windows tests that were generating \r\n instead of just \n

Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7
Merge branch 'main' into htmlConverter
01dbc7d
@Amndeep7
lint
edb0fab 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 16, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
4 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Amndeep7 Amndeep7 merged commit 94473d1 into main Apr 16, 2026
18 checks passed
@Amndeep7 Amndeep7 deleted the htmlConverter branch April 16, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@em-c-rod em-c-rod em-c-rod left review comments

@Amndeep7 Amndeep7 Amndeep7 approved these changes

+1 more reviewer

@kemley76 kemley76 kemley76 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@charleshu-8 charleshu-8

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@charleshu-8 @em-c-rod @kemley76 @Amndeep7