Improve ResponseDate parsing #1663
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable parsing of additional date formats (including nanosecond precision) in CopyObjectResult.
This makes the minio-java client compatible with SeaweedFS responses.
Problem
Currently, ResponseDate parses only two formats:
If the date contains nanoseconds, parsing fails with a DateTimeParseException:
Example
SeaweedFS response (nanoseconds):
MinIO response (milliseconds):
Both are valid according to the S3 API spec (LastModified is any string DateTime parsable by strtotime).
Solution
Use ZonedDateTime.parse without a custom formatter.
It falls back to ISO_ZONED_DATE_TIME and supports all previously accepted formats as well as those with nanoseconds.
Additionally, it simplifies the code.
Compatibility
No breaking changes - existing formats continue to be parsed correctly.