-
-
Notifications
You must be signed in to change notification settings - Fork 405
Moved OpenXml specific logic to new MiniExcel.OpenXml project #918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Moved OpenXml specific logic to new MiniExcel.OpenXml project #918
Conversation
- OpenXml-related utilities, algorithms, models, etcetera have been moved from MiniExcel.Core to the new MiniExcel.OpenXml project for better separation of concerns and mantainability. - Renamed project MiniExcel.Core.Tests to MiniExcel.OpenXml.Tests. - Updated references, namespaces, and project files accordingly. - Introduced MiniExcelConverter utility for CSV/XLSX conversion and updated documentation. - Condensed logic for parsing Excel column names and calculating indexes into class ColumnHelper, now renamed CellReferenceConverter and made available for external use.
Summary of ChangesHello @michelebastione, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant architectural change by decoupling the OpenXml and Csv functionalities into separate projects. The primary goal is to allow for independent packaging and maintenance of these components, making the library more modular and flexible. This refactoring involved moving a substantial amount of OpenXml-related code, updating internal references, and centralizing common utilities like cell reference conversions. While a large change, it sets the foundation for a more maintainable and extensible MiniExcel library. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully decouples the OpenXml and Csv logic by moving OpenXml-specific components into a new MiniExcel.OpenXml project. The changes involve extensive file renames, namespace adjustments, and updates to using statements across the codebase, which is a significant step towards better separation of concerns and maintainability. The introduction of the MiniExcelConverter utility class centralizes conversion methods, and documentation has been updated to reflect these API changes. Overall, the refactoring is well-executed and aligns with the stated goals of the pull request.
izanhzh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely agree with this direction! 👍
This PR aims to decouple OpenXml and Csv logic as much as possible by moving most of the OpenXml specific logic from
MiniExcel.Coreto the newMiniExcel.OpenXmlproject.MiniExcel.Csvnow depends exclusively from the common mapping logic inMiniExcel.Core. This way if we decide to move in this direction, we can provide separate packages forMiniExcel.OpenXmlandMiniExcel.Csvthat don't depend on each other.Even though this is a big PR the majority of the modifications are simply renaming files and adjusting namespaces. A brief summary follows:
MiniExcel.Coreto the newMiniExcel.OpenXmlproject for better separation of concerns and mantainability.MiniExcel.Core.TeststoMiniExcel.OpenXml.Tests.MiniExcelConverterutility in the mainMiniExcelproject for Csv/Xlsx conversion and updated documentation. This is a breaking change compared to the last prerelease version, as previously the conversion methods were found inCsvExporter.ColumnHelper, now renamedCellReferenceConverterand made available for external use, so that it also closes [Feature] - Public util methods #913@shps951023 @izanhzh What is your opinion? Do you agree on moving forward with this direction for the project?