Skip to content

Revise local model usage instructions in README#744

Open
Sweaterdog wants to merge 7 commits into
developfrom
Sweaterdog-update-andy-model-info
Open

Revise local model usage instructions in README#744
Sweaterdog wants to merge 7 commits into
developfrom
Sweaterdog-update-andy-model-info

Conversation

@Sweaterdog
Copy link
Copy Markdown
Contributor

Updated local model recommendations and installation instructions.

@Sweaterdog Sweaterdog marked this pull request as ready for review March 26, 2026 09:24
Copilot AI review requested due to automatic review settings March 26, 2026 09:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates local model guidance and refreshes the Andy local profile configuration to point users toward LM Studio.

Changes:

  • Updated README local-model recommendation from Ollama to LM Studio and linked to a Hugging Face collection.
  • Replaced the andy-4 profile JSONs with a new andy-4.2 profile.
  • Updated the commented example profile path in settings.js.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
settings.js Updates the commented sample profile path to the new Andy profile filename.
profiles/andy-4.json Removes the old Andy-4 Ollama profile.
profiles/andy-4-reasoning.json Removes the old “reasoning/thinking” Andy-4 profile.
profiles/andy-4.2.json Adds a new Andy-4.2 local profile targeting an OpenAI-compatible endpoint.
README.md Revises local-model instructions to recommend LM Studio and links to Hugging Face.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread profiles/andy-4.2.json Outdated
Comment thread profiles/andy-4.2.json Outdated
Comment thread README.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
riqvip
riqvip previously approved these changes Apr 4, 2026
@riqvip riqvip requested a review from uukelele April 15, 2026 19:20
Copy link
Copy Markdown
Contributor

@uukelele uukelele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should do what at copilot said first

@Sweaterdog
Copy link
Copy Markdown
Contributor Author

Sweaterdog commented Apr 16, 2026

I think you should do what at copilot said first

Elaborate, depending where I look I see 3 different "first things."

@uukelele
Copy link
Copy Markdown
Contributor

I think you should do what at copilot said first

Elaborate, depending where I look I see 3 different "first things."

You say no need, I believe yes need. At least add LMStudio as a custom provider

@riqvip riqvip requested a review from uukelele May 3, 2026 22:48
Ninot1Quyi added a commit that referenced this pull request May 3, 2026
Bring in the Andy 4.2 profile and README guidance from the upstream PR while
converting the profile to this branch's provider-registry schema. LM Studio is
registered as a local OpenAI-compatible provider/embedding provider, and the
OpenAI-compatible adapter now respects an explicit null keyName for no-key
local servers.

Constraint: Preserve the PR merge record and contributor commits instead of squashing
Constraint: Profiles must use the local provider/model schema, not the PR's legacy api/model shorthand
Rejected: Keep the PR profile format unchanged | it bypasses the provider registry used by this branch
Confidence: high
Scope-risk: moderate
Tested: node -e "for (const f of ['settings_llm_providers.example.json','settings_llm_providers.json','profiles/andy-4.2.json']) if (require('fs').existsSync(f)) JSON.parse(require('fs').readFileSync(f,'utf8'))"
Tested: MINDCRAFT_LLM_PROVIDERS_PATH=settings_llm_providers.example.json node --input-type=module provider resolution smoke
Tested: npx eslint src/models/_model_map.js src/models/openai_compatible.js
Tested: git diff --check
Not-tested: Live LM Studio Andy 4.2 request; requires local LM Studio server and model
Co-authored-by: OmX <omx@oh-my-codex.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants