Skip to content

EVM: Add cross chain swap operation to safeguards #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PedroAraoz merged 2 commits into from
Mar 30, 2026
Merged

EVM: Add cross chain swap operation to safeguards #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f0a344
evm: add cross chain swap operation to safeguards
PedroAraoz Mar 30, 2026
eb1ce28
update test to include cross chain swap
PedroAraoz Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/evm/contracts/safeguards/OperationsValidator.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,9 @@ contract OperationsValidator is
*/
function _isSafeguardValid(Operation memory operation, Safeguard memory safeguard) internal pure returns (bool) {
if (safeguard.mode == uint8(0)) revert OperationsValidatorNoneAllowed();
if (operation.opType == uint8(OpType.Swap)) return _isSwapOperationValid(operation, safeguard);
if (operation.opType == uint8(OpType.Swap) || operation.opType == uint8(OpType.CrossChainSwap)) {
return _isSwapOperationValid(operation, safeguard);
}
if (operation.opType == uint8(OpType.Transfer)) return _isTransferOperationValid(operation, safeguard);
if (operation.opType == uint8(OpType.Call)) return _isCallOperationValid(operation, safeguard);
revert OperationsValidatorUnknownOperationType(uint8(operation.opType));
Expand Down
3 changes: 2 additions & 1 deletion packages/evm/test/safeguards/OperationsValidator.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { OperationsValidator } from '../../types/ethers-contracts/index.js'
import {
CallSafeguardMode,
createCallOperation,
createCrossChainSwapOperation,
createDeniedAccountSafeguard,
createDeniedChainSafeguard,
createDeniedSelectorSafeguard,
Expand Down Expand Up @@ -122,7 +123,7 @@ describe('OperationsValidator', () => {
})

context('TokenIn', () => {
const operation = createSwapOperation({ tokensIn: [{ token: token1, amount: 1n }], tokensOut: [] })
const operation = createCrossChainSwapOperation({ tokensIn: [{ token: token1, amount: 1n }], tokensOut: [] })

context('when the token in is allowed', () => {
const safeguard = createOnlyAccountSafeguard(SwapSafeguardMode.TokenIn, token1)
Expand Down
Loading