Conversation
The shared node-simple-pnpm workflow skips the test step unless it also starts a Platforma backend (pl-start-for-tests), so no package test has ever run in CI here. Add a dedicated job that runs the test script of every package that has one, with Go and Docker, and make build/publish wait for it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Add a lint job that installs golangci-lint v2.11.4 (the version used locally) and runs the lint script of every package that has one; the build/publish job waits for it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
golangci-lint-action v8 has no install-only mode and lints a single working directory itself, which fails at the repo root where there is no Go module. Install the pinned binary with the official script and keep the per-package loop. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Smoke test for the reworked CI workflow (Package tests / Package lint jobs and the test gate on build/publish) against a package other than job-wrapper. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Smoke test of the reworked CI workflow from #52 against a package other than job-wrapper: a documentation-only change to line-counter with a patch changeset, to confirm the new
Package tests/Package lintjobs and the test gate on build/publish leave the other packages green.Based on the
MILAB-6910-job-wrapperbranch, so the wrapper commits show in the diff; only the last commit is this PR's own change. Not meant to be merged before #52.🤖 Generated with Claude Code