fix: do not directly specify inlineCode font size#578
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the default inlineCode typography in both Material 2 and Material 3 renderers so inline code does not force a specific font size when merged into surrounding text styles (e.g., headings).
Changes:
- Set
inlineCodefontSizetoTextUnit.Unspecifiedwhile keeping monospace font family (M2 + M3). - Add
TextUnitimport required for the new default.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| multiplatform-markdown-renderer-m3/src/commonMain/kotlin/com/mikepenz/markdown/m3/MarkdownTypography.kt | Adjusts M3 inline code style to avoid overriding surrounding font size. |
| multiplatform-markdown-renderer-m2/src/commonMain/kotlin/com/mikepenz/markdown/m2/MarkdownTypography.kt | Adjusts M2 inline code style to avoid overriding surrounding font size. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Thank you @zxbmmmmmmmmm for the contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the markdown typography configuration for both Material 2 and Material 3 Compose implementations to improve the handling of inline code styling. The main change is to explicitly set the font size of inline code elements to
TextUnit.Unspecified, ensuring they inherit the surrounding text size rather than overriding it. This helps maintain consistent appearance in markdown rendering.Before
After
Type of change
How Has This Been Tested?
./gradlew :multiplatform-markdown-renderer:assemble./gradlew apiCheckChecklist: