Repository navigation
crosvm: Guard socket cleanup, add hugepage, vhost-net and initial balloon sizing - #640
Merged
Merged
Conversation
Setting socket to null fails when generating preStart because the cleanup command evaluates it unconditionally. Fix this by guarding the command with a socket != null check, similar to the implementation in cloud-hypervisor.
crosvm supports a --hugepages switch to advise the kernel to use transparent hugepages. Pass --hugepages when requested in the configuration and document the difference compared to cloud-hypervisor.
crosvm supports TAP vhost-net acceleration similar to QEMU, but currently tap.vhost is ignored for crosvm. Add the per-interface vhost-net flag and document crosvm support plus the required host device access.
crosvm can set the initial balloon through --init-mem. Pass the memory outside the balloon (mem minus initialBalloonMem) and reject sizes larger than mem.
SuperSandro2000
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(see individual commits)