[cpptrace] add wasm support#52674
Merged
Merged
Conversation
Contributor
Author
|
I have opened a PR upstream a few weeks ago for the patch in this port: jeremy-rifkin/cpptrace#329 |
dg0yt
reviewed
Jul 1, 2026
| #undef IS_WINDOWS | ||
| #define IS_WINDOWS 1 | ||
| -#elif defined(__linux) | ||
| +#elif defined(__linux) || defined(__EMSCRIPTEN__) |
Contributor
There was a problem hiding this comment.
Ooh, why does upstream use __linux and not __linux__?
Contributor
Author
There was a problem hiding this comment.
Hrmm, not sure. Shall we patch here?
Contributor
There was a problem hiding this comment.
no need, I have already verified through the clang source code that emscripten does not define linux
BillyONeal
approved these changes
Jul 2, 2026
BillyONeal
left a comment
BillyONeal
left a comment
Member
There was a problem hiding this comment.
Seems reasonable, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.