-
Notifications
You must be signed in to change notification settings - Fork 7.2k
[nggmsg] New port #48735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[nggmsg] New port #48735
Conversation
添加nggmsg库的vcpkg.json和portfile.cmake配置文件,支持通过vcpkg安装该库
原代码会错误删除整个debug目录,现改为仅删除debug/include目录以保留其他调试文件
添加库的使用说明文档,同时优化portfile.cmake配置: - 移除BUILD_TESTING选项 - 添加usage文件安装 - 清理空目录 - 启用相关VCPKG策略
在vcpkg.json中添加supports字段以限制nggmsg库在非x86架构上使用
- 使用变量VERSION替代硬编码版本号 - 简化清理逻辑,移除冗余操作 - 添加cmake配置修复 - 保留版权文件安装
BillyONeal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
Would you accept xhk-nggmsg ? That would follow the GitHubOrg - GitHubRepo pattern for which we do not require demonstrating that the name is strongly associated with that upstream.
|
|
||
| vcpkg_cmake_install() | ||
|
|
||
| vcpkg_cmake_config_fixup(PACKAGE_NAME "my_sample_lib") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like you probably want this to be named something like nggmsg? This is the name the rest of the world expects to say when they name your library.
| @@ -0,0 +1,17 @@ | |||
| # Usage | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is vcpkg's generated usage text incorrect? We generally avoid including full examples, and this case isn't even really an example because the library isn't used. Moreover, portfile.cmake suggests find_package(my_sample_lib but you don't show that here.
添加nggmsg库的vcpkg.json和portfile.cmake配置文件,支持通过vcpkg安装该库
find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.