Skip to content

Conversation

@xhk
Copy link

@xhk xhk commented Dec 8, 2025

添加nggmsg库的vcpkg.json和portfile.cmake配置文件,支持通过vcpkg安装该库

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

xhk added 6 commits December 8, 2025 10:40
添加nggmsg库的vcpkg.json和portfile.cmake配置文件,支持通过vcpkg安装该库
原代码会错误删除整个debug目录,现改为仅删除debug/include目录以保留其他调试文件
添加库的使用说明文档,同时优化portfile.cmake配置:
- 移除BUILD_TESTING选项
- 添加usage文件安装
- 清理空目录
- 启用相关VCPKG策略
在vcpkg.json中添加supports字段以限制nggmsg库在非x86架构上使用
- 使用变量VERSION替代硬编码版本号
- 简化清理逻辑,移除冗余操作
- 添加cmake配置修复
- 保留版权文件安装
@BillyONeal BillyONeal changed the title build(nggmsg): 添加nggmsg库的vcpkg配置 [nggmsg] New port Dec 9, 2025
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.

Would you accept xhk-nggmsg ? That would follow the GitHubOrg - GitHubRepo pattern for which we do not require demonstrating that the name is strongly associated with that upstream.


vcpkg_cmake_install()

vcpkg_cmake_config_fixup(PACKAGE_NAME "my_sample_lib")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like you probably want this to be named something like nggmsg? This is the name the rest of the world expects to say when they name your library.

@@ -0,0 +1,17 @@
# Usage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is vcpkg's generated usage text incorrect? We generally avoid including full examples, and this case isn't even really an example because the library isn't used. Moreover, portfile.cmake suggests find_package(my_sample_lib but you don't show that here.

@BillyONeal BillyONeal marked this pull request as draft December 9, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants