Fix error message formatting in uf2conv#106
Open
PetteriAimonen wants to merge 1 commit into
Open
Conversation
Some of the error messages were trying to concatenate int to str. This gave "TypeError: can only concatenate str (not "int") to str" Fixed the formatting and made the errors more helpful by including the addresses involved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the error messages were trying to concatenate int to str.
This gave error such as:
Fixed the formatting and made the errors more helpful by including the addresses involved.
Converted the
if foo: assert Falseconstruct to more idiomaticassert !foo. There is no performance penalty as Python does not evaluate the second argument of assert unless it fails.