Do not inherit dataclass defaults from field() overrides without a default - #11665
Open
Henry Su (hsusul) wants to merge 1 commit into
Open
Do not inherit dataclass defaults from field() overrides without a default#11665Henry Su (hsusul) wants to merge 1 commit into
Henry Su (hsusul) wants to merge 1 commit into
Conversation
…t one. CPython treats `x: int = field()` as removing the parent default, so the synthesized __init__ parameter is required. Bare annotations still inherit. Fixes microsoft#11660
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x: int = field()removes the parent default at runtime, soFoo()is missing a required argument.x: intstill inherit, matching CPython.Test plan
npx jest typeEvaluator4.test.ts -t "DataClass" --forceExit(frompackages/pyright-internal)Foo()is reported as missingxwhenFoooverridesx: int = field()in the language server