Pull Pylance with Pyright 1.1.412 - #11639
Conversation
|
🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR. |
| displayName: pnpm install | ||
| inputs: | ||
| script: npm run install:all | ||
| script: pnpm run install:all |
There was a problem hiding this comment.
Warning · Non-blocking recommendation
Azure invokes ambient pnpm despite package.json pinning pnpm@10.12.2, unlike GitHub's explicit setup. Activate the pinned package manager after Node setup in both build and release pipelines.
| working-directory: ${{ inputs.working-directory }} | ||
| env: | ||
| NPM_CONFIG_REGISTRY: https://registry.npmjs.org/ | ||
| run: pnpm run install:all |
There was a problem hiding this comment.
Warning · Non-blocking recommendation
This action accepts arbitrary working-directory values but runs pnpm run install:all, which only works where that script exists; the CFS action runs pnpm install directly. Use the same install command or narrow the advertised directory contract.
Rich Chiodo (rchiodo)
left a comment
Rich Chiodo (rchiodo)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Rich Chiodo (rchiodo)
added
the
review-auto:approved
| working-directory: ${{ inputs.working-directory }} | ||
| env: | ||
| NPM_CONFIG_REGISTRY: https://registry.npmjs.org/ | ||
| run: pnpm run install:all |
There was a problem hiding this comment.
Warning · Non-blocking recommendation
The public-registry path runs pnpm run install:all, while the CFS path runs pnpm install; package-scoped working directories without an install:all script therefore have a different contract and may break fork builds. Use the same frozen-lockfile install command in both paths, varying only authentication and registry configuration.
Rich Chiodo (rchiodo)
left a comment
Rich Chiodo (rchiodo)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Heejae Chang (heejaechang)
left a comment
Heejae Chang (heejaechang)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
3 participants
No description provided.