CHORE: add extra_params connection-string regression tests#545
Draft
bewithgaurav wants to merge 1 commit into
Draft
CHORE: add extra_params connection-string regression tests#545bewithgaurav wants to merge 1 commit into
bewithgaurav wants to merge 1 commit into
Conversation
adds coverage for the extra_params scenarios from #427: verbatim append, keywords containing spaces (e.g. Connection Timeout), and an Authentication= mode alongside a spaced keyword not injecting Trusted_Connection (the FA001 case fixed in 1.7.3, #533). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| extra = "Encrypt=no;TrustServerCertificate=yes" | ||
| conn_params = { | ||
| "NAME": "testdb", | ||
| "HOST": "localhost", |
| """ | ||
| conn_params = { | ||
| "NAME": "testdb", | ||
| "HOST": "localhost", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds regression tests for the extra_params connection-string handling, covering the scenarios raised in #427:
Connection Timeout=30) survives verbatimAuthentication=mode alongside a spaced keyword does not injectTrusted_Connection(the FA001 case fixed in 1.7.3, FIX: skip Trusted_Connection/SSPI when Authentication= is explicit #533)test-only, no code change. all under
testapp/tests/test_base.py(SimpleTestCase, no db).