FIX: Schema flushing and model schemas - #497
Open
benclark158 wants to merge 27 commits into
Open
Conversation
added 9 commits
February 9, 2026 13:03
Author
|
@microsoft-github-policy-service agree |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 497 in repo microsoft/mssql-django |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the mssql-django backend’s support for non-default SQL Server schemas, aiming to ensure models using schema-qualified db_table names behave correctly in migrations, flushing, and introspection.
Changes:
- Add schema-aware FK constraint disabling/enabling during
flush. - Add schema-qualified table handling in introspection (table listing and per-table queries).
- Create missing schemas automatically during
CREATE TABLEmigrations, plus add test coverage/models/migrations for non-dbo schemas.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
mssql/schema.py |
Adds auto-creation of schemas during create_model() and introduces sql_create_schema. |
mssql/operations.py |
Updates sql_flush() to include TABLE_SCHEMA so constraints are altered with schema-qualified table names. |
mssql/introspection.py |
Updates introspection to return schema-qualified table names and to handle schema-qualified inputs for several introspection methods. |
testapp/models.py |
Adds test models with db_table set to [events].[...] and [dbo].[...]. |
testapp/migrations/0026_parentschema_childschema.py |
Creates ParentSchema/ChildSchema tables in the [events] schema. |
testapp/migrations/0027_create_dboschema.py |
Creates DboSchema table in the [dbo] schema. |
testapp/tests/test_schema.py |
Adds tests intended to validate flushing and introspection with non-default schemas. |
Comment on lines
163
to
166
| # map pyodbc's cursor.columns to db-api cursor description | ||
| _schema_name, table_name = get_table_name_with_schema(table_name=table_name) | ||
| columns = [[c[3], c[4], c[6], c[6], c[6], c[8], c[10], c[12]] for c in cursor.columns(table=table_name)] | ||
|
|
| TABLE_TYPE, | ||
| CAST(ep.value AS VARCHAR) AS COMMENT | ||
| FROM INFORMATION_SCHEMA.TABLES i | ||
| LEFT JOIN sys.tables t ON t.name = i.TABLE_NAME |
Comment on lines
+67
to
+71
| sql_create_schema = ( | ||
| "IF NOT EXISTS (SELECT 1 FROM sys.schemas WHERE name = '%(schema)s') BEGIN " | ||
| "EXEC('CREATE SCHEMA [%(schema)s]') " | ||
| "END" | ||
| ) |
Comment on lines
+1504
to
+1510
|
|
||
| sql = self.sql_create_schema % { | ||
| 'schema': schema_name.strip('[').strip(']') | ||
| } | ||
|
|
||
| self.execute(sql, None) | ||
|
|
| def test_inspectdb(self): | ||
| connection = connections['default'] | ||
|
|
||
| descs = connection.introspection.get_table_description(cursor=connection.cursor(), table_name='[events].[ParentSchema]') |
saurabh500
reviewed
May 2, 2026
saurabh500
reviewed
May 2, 2026
saurabh500
reviewed
May 2, 2026
saurabh500
reviewed
May 2, 2026
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@benclark158 - thanks for your contribution! |
Author
Apologies for the delay @bewithgaurav. The changes should have all been made now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Meta.db_table = [schema].[table_name]flushcommand to work as expected for models with non default schemasI have added tests for tables with different defined migrations as well as flushing
Fixes: #496