compute_vm_create: Update default VM size from Standard_DS1_v2 to Standard_D2s_v5 and Fix Option Bindings for VMSS update by haagha · Pull Request #2415 · microsoft/mcp

haagha · 2026-04-15T21:02:35Z

What does this PR do?

This PR changes the default size of VM and VMSS creation from Standard_DS1_v2 to Standard_DS2_v2.
This PR will also fixes bugs relating to VMSS update options binding.

GitHub issue number?

#2244

Pre-merge Checklist

… commands and documentation

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates Azure Compute tool defaults to use a newer VM size and fixes option parsing so vmss update can accept capacity and related tri-state flags.

Changes:

Change default VM size for vm create / vmss create from Standard_DS1_v2 to Standard_D2s_v5 across service logic, tests, and docs.
Fix VMSS update option typing by making --capacity, --overprovision, and --enable-auto-os-upgrade nullable to distinguish “not provided” vs “set”.
Add changelog entries and update server docs/e2e prompts to reflect the new defaults.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tools/Azure.Mcp.Tools.Compute/tests/Azure.Mcp.Tools.Compute.UnitTests/Vmss/VmssUpdateCommandTests.cs	Adds a new validation case for `--capacity` in `vmss update`.
tools/Azure.Mcp.Tools.Compute/tests/Azure.Mcp.Tools.Compute.UnitTests/Vmss/VmssCreateCommandTests.cs	Updates expected VMSS default size to `Standard_D2s_v5`.
tools/Azure.Mcp.Tools.Compute/tests/Azure.Mcp.Tools.Compute.UnitTests/Vm/VmCreateCommandTests.cs	Updates expected VM default size to `Standard_D2s_v5`.
tools/Azure.Mcp.Tools.Compute/tests/Azure.Mcp.Tools.Compute.LiveTests/ComputeCommandTests.cs	Updates live test assertions for VM size.
tools/Azure.Mcp.Tools.Compute/src/Services/ComputeService.cs	Changes default VM size constant and related comments.
tools/Azure.Mcp.Tools.Compute/src/Options/ComputeOptionDefinitions.cs	Updates help text and makes VMSS update options nullable.
tools/Azure.Mcp.Tools.Compute/src/ComputeSetup.cs	Updates tool description default-size text.
tools/Azure.Mcp.Tools.Compute/src/Commands/Vmss/VmssCreateCommand.cs	Updates command description default-size text.
tools/Azure.Mcp.Tools.Compute/src/Commands/Vm/VmCreateCommand.cs	Updates command description default-size text.
servers/Azure.Mcp.Server/docs/e2eTestPrompts.md	Updates e2e prompt to the new default size.
servers/Azure.Mcp.Server/docs/azmcp-commands.md	Updates docs for default size for VM and VMSS create.
servers/Azure.Mcp.Server/changelog-entries/1776182026573.yaml	Adds changelog entry for VMSS update option fix.
servers/Azure.Mcp.Server/changelog-entries/1775768065287.yaml	Adds changelog entry for default VM size change.
eng/tools/ToolDescriptionEvaluator/prompts/namespace-tools.json	Updates evaluator prompt tool description default-size text.

Copilot · 2026-04-15T21:09:27Z


-    // Default VM size matching Azure CLI (az vm create --size default)
-    private const string DefaultVmSize = "Standard_DS1_v2";
+    // Default VM size (D-series v5: 2 vCPU, 8 GB RAM, available in all regions)


The comment claims Standard_D2s_v5 is “available in all regions”, which is not a safe guarantee and can become inaccurate (availability varies by region/subscription and can change over time). Consider removing the region-availability claim and keeping the comment to the intent (tool default) and the approximate spec, or link to authoritative docs if the statement must remain.

Suggested change

// Default VM size (D-series v5: 2 vCPU, 8 GB RAM, available in all regions)

// Default VM size (D-series v5, approximately 2 vCPU and 8 GB RAM)

Copilot · 2026-04-15T21:09:28Z

                        [--os-disk-type <os-disk-type>]

-Defaults to the Azure CLI baseline of Standard_DS1_v2 size and the Ubuntu2404 image when not specified. When new NSG rules are created, SSH/RDP access is allowed from any source unless `--source-address-prefix` is provided.
+Defaults to the Azure CLI baseline of Standard_D2s_v5 size and the Ubuntu2404 image when not specified. When new NSG rules are created, SSH/RDP access is allowed from any source unless `--source-address-prefix` is provided.


This line states “Defaults to the Azure CLI baseline of Standard_D2s_v5”, but the tool’s default is a product choice and may not match Azure CLI defaults (which have historically differed and may change independently). Suggest rewording to avoid attributing this to Azure CLI, e.g. “Defaults to Standard_D2s_v5 size …” unless there’s a verified source that Azure CLI’s baseline is indeed D2s_v5.

Suggested change

Defaults to the Azure CLI baseline of Standard_D2s_v5 size and the Ubuntu2404 image when not specified. When new NSG rules are created, SSH/RDP access is allowed from any source unless `--source-address-prefix` is provided.

Defaults to Standard_D2s_v5 size and the Ubuntu2404 image when not specified. When new NSG rules are created, SSH/RDP access is allowed from any source unless `--source-address-prefix` is provided.

Copilot · 2026-04-15T21:09:28Z

    [Theory]
    [InlineData("--vmss-name test-vmss --resource-group test-rg --subscription sub123 --upgrade-policy Automatic", true)]
+    [InlineData("--vmss-name test-vmss --resource-group test-rg --subscription sub123 --capacity 5", true)]
    [InlineData("--vmss-name test-vmss --resource-group test-rg --subscription sub123 --tags env=test", true)]
    [InlineData("--vmss-name test-vmss --resource-group test-rg --subscription sub123 --scale-in-policy OldestVM", true)]
    [InlineData("--vmss-name test-vmss --resource-group test-rg --subscription sub123", false)] // No update property


The changelog claims vmss update now accepts --capacity, --overprovision, and --enable-auto-os-upgrade, but this test only adds coverage for --capacity. Add InlineData cases for --overprovision true/false and --enable-auto-os-upgrade true/false (and any expected failure cases) to ensure the option-type change actually fixes parsing/binding for those flags.

Copilot · 2026-04-15T21:09:28Z

+changes:
+  - section: "Bugs Fixed"
+    description: "Fixed `vmss update` command not accepting `--capacity`, `--overprovision`, or `--enable-auto-os-upgrade` options due to option type mismatch"


This PR includes a functional bug fix to vmss update option parsing in addition to the default VM size change described by the PR title, and the PR description template is still unfilled. Please update the PR description (and ideally the title) to explicitly include the vmss update option parsing fix, or split into separate PRs if you want to keep changes scoped to the default-size update.

Update default VM size from Standard_DS1_v2 to Standard_D2s_v5 across…

d8ea801

… commands and documentation

haagha requested a review from g2vinay as a code owner April 15, 2026 21:02

Copilot AI review requested due to automatic review settings April 15, 2026 21:02

haagha requested review from a team as code owners April 15, 2026 21:02

github-project-automation bot added this to Azure MCP Server Apr 15, 2026

haagha requested review from KarishmaGhiya, chidozieononiwu, conniey, hallipr, jairmyree and xiangyan99 April 15, 2026 21:02

github-project-automation bot moved this to Untriaged in Azure MCP Server Apr 15, 2026

github-actions bot added the tools-Compute label Apr 15, 2026

haagha changed the title ~~compute_vm_create: Update default VM size from Standard_DS1_v2 to Standard_D2s_v5 across commands and documentation~~ compute_vm_create: Update default VM size from Standard_DS1_v2 to Standard_D2s_v5 and Fix Option Bindings for VMSS update Apr 15, 2026

Copilot AI reviewed Apr 15, 2026

View reviewed changes

Copilot started reviewing on behalf of haagha April 15, 2026 21:13 View session

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

compute_vm_create: Update default VM size from Standard_DS1_v2 to Standard_D2s_v5 and Fix Option Bindings for VMSS update#2415

compute_vm_create: Update default VM size from Standard_DS1_v2 to Standard_D2s_v5 and Fix Option Bindings for VMSS update#2415
haagha wants to merge 1 commit intomicrosoft:mainfrom
haagha:haagha/fix-default-vmsize

haagha commented Apr 15, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	// Default VM size (D-series v5: 2 vCPU, 8 GB RAM, available in all regions)
	// Default VM size (D-series v5, approximately 2 vCPU and 8 GB RAM)

	Defaults to the Azure CLI baseline of Standard_D2s_v5 size and the Ubuntu2404 image when not specified. When new NSG rules are created, SSH/RDP access is allowed from any source unless `--source-address-prefix` is provided.
	Defaults to Standard_D2s_v5 size and the Ubuntu2404 image when not specified. When new NSG rules are created, SSH/RDP access is allowed from any source unless `--source-address-prefix` is provided.

Conversation

haagha commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

GitHub issue number?

Pre-merge Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

haagha commented Apr 15, 2026 •

edited

Loading