Repository navigation
fix: cap mcp below 2 so a fresh install can start - #54
Open
Vishal Habib (vishalhabib99) wants to merge 1 commit into
Open
Vishal Habib (vishalhabib99) wants to merge 1 commit into
Vishal Habib (vishalhabib99) wants to merge 1 commit into
Conversation
mcp 2.x removed mcp.client.streamable_http.streamablehttp_client, which interviewer/connection.py imports. With mcp>=1.10.1 unbounded, pip install mcp-interviewer now resolves mcp 2.3.0 and the CLI fails on import.
Author
|
@microsoft-github-policy-service agree |
Author
|
Hi, just checking whether this one is on your radar. It's a small fix (cap mcp below 2 so a fresh install can start) and the branch is still mergeable. Happy to change anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pyproject.tomlasks formcp>=1.10.1with no upper bound. mcp 2.x is now the latest on PyPI (2.3.0), and it removedmcp.client.streamable_http.streamablehttp_client(renamedstreamable_http_client).src/mcp_interviewer/interviewer/connection.pyimports the old name, so a freshpip install mcp-interviewer, the install command in the README, gets mcp 2.3.0 and the CLI fails on import:Resolution today (
uv pip compile, Python 3.12):mcp-interviewer(PyPI 0.0.12)2.3.0, which breaks1.30.0uv.lockstill pins mcp 1.10.1, souv syncusers and CI don't see this. Only pip and fresh resolutions do.Change
mcp>=1.10.1,<2inpyproject.tomland the matchingrequires-distline inuv.lock. No locked versions change. Moving to the mcp 2.x client API can come later as a separate change.Checked
streamablehttp_clientinmcp.client.streamable_http. I checked this directly.uv pip compilegives the resolutions in the table above.pytest: 19 passed on this branch.