Fix: include all Windows VMs in Azure Hybrid Benefit reports#1845
Merged
Fix: include all Windows VMs in Azure Hybrid Benefit reports#1845
Conversation
microsoft-github-policy-service
bot
requested review from
aromano2,
arthurclares and
flanakin
microsoft-github-policy-service
bot
added
the
Skill: DevOps
microsoft-github-policy-service
bot
added
Skill: Documentation
Copilot
AI
changed the title
[WIP] Fix missing Windows VMs from Hybrid Benefits overviews
Fix: Include all Windows VMs in Azure Hybrid Benefit workbooks regardless of publisher
Oct 10, 2025
Replace hardcoded publisher checks (MicrosoftWindowsServer, microsoftsqlserver) with OS type checks (storageProfile.osDisk.osType) so that Windows VMs from all publishers (e.g., esri, safesoftwareinc) appear in AHB overviews. Also removes the now-unnecessary custom image exclusion filter (extend OS=imageReference.id / where isnull(OS)) and consolidates the redundant OS type check in the summary query. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
flanakin
force-pushed
the
copilot/fix-hybrid-benefits-overview
branch
from
a1532ff to
9d21ca5
Compare
flanakin
changed the title
microsoft-github-policy-service
bot
added
the
Micro PR 🔬
flanakin
approved these changes
Mar 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the Azure Hybrid Benefit (AHB) workbook reports where Windows VMs from non-Microsoft publishers (e.g., esri, safesoftwareinc) were excluded from AHB overviews. The fix replaces hardcoded publisher checks with OS type checks (storageProfile.osDisk.osType), making the queries publisher-agnostic and also removes now-unnecessary custom image exclusion filters.
Changes:
- KQL queries in both AHB workbooks updated to filter on
osDisk.osType == 'Windows'instead of image publisher names - Custom image exclusion filter (
extend OS=imageReference.id / where isnull(OS)) removed fromAHB/AHB.workbook - Changelog updated with fix entry under v14
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/workbooks/optimization/Compute/AHB.workbook |
Updated AHB Disabled and AHB Enabled queries to use osDisk.osType checks instead of publisher checks |
src/workbooks/optimization/AHB/AHB.workbook |
Updated four queries (AHB Disabled, AHB Enabled, two summary charts) to use osDisk.osType checks and removed custom image exclusion filters |
docs-mslearn/toolkit/changelog.md |
Added changelog entry for the fix under FinOps workbooks v14, updated ms.date to 03/02/2026 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Replace hardcoded publisher checks (
MicrosoftWindowsServer,microsoftsqlserver) with OS type checks (storageProfile.osDisk.osType) so that Windows VMs from all publishers (e.g., esri, safesoftwareinc) appear in AHB overviews.Also removes the now-unnecessary custom image exclusion filter (
extend OS=imageReference.id/where isnull(OS)) and consolidates the redundant OS type check in the summary query.Fixes #1793
📋 Checklist
🔬 How did you test this change?
📦 Deploy to test?
🙋♀️ Do any of the following that apply?
📑 Did you update
docs/changelog.md?📖 Did you update documentation?